Re: patch review: avoid com delay() in VMs

Martin Husemann <[email protected]>
Newsgroups gmane.os.netbsd.devel.kernel
Message-ID <[email protected]>
On Tue, Feb 04, 2025 at 09:11:11PM +0100, Emile `iMil' Heitor wrote:
> 
> com_attach_subr() in sys/dev/ic/com.c has a delay(10000) waiting for
> output to finish, this is very unlikely to be useful inside a virtual
> machine and slows down boot time in such machine.
> I propose the following approach:

This looks good, one minor nit:

We could replace the architecture #if with a

#ifdef __HAVE_VIRTUAL_HOST_P

(or some better name) and add that #define to
{i386,amd64}/include/types.h (and I think we also document the __HAVE_
stuff somewhere).

Martin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.