Re: Possible garbage value return in IXL
Manuel Bouyer <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Mar 25, 2025 at 01:31:46PM +0000, Emmanuel Nyarko wrote: > > https://github.com/Emmankoko/altq_refactoring_gsoc/commit/918c9c8056ccc2ed7da214bbf3c8c3cd4071fa8c? > returning garbage value · Emmankoko/altq_refactoring_gsoc@918c9c8 > github.com > > I don?t really understand the need of the return value in this case. But would appreciate some global reviews here. > > Is a return 0 or 1 relevant to the logic here. It looks like some interrupt handling. it is interrupt handling; return 0 if the iterrupt was not for us, 1 if it was. > > Is it supposed to always return 1? No, if we know the interrupt was not for us return 0. -- Manuel Bouyer <[email protected]> NetBSD: 26 ans d'experience feront toujours la difference --