Re: [PATCH] Add posix_spawn_file_actions_addclosefrom_np

On Jun 29, 2026, at 2:12=E2=80=AFAM, Martin Husemann <[email protected]> wro=
te:
>=20
> =EF=BB=BFOn Sun, May 10, 2026 at 02:26:47PM -0700, Chris Hanson wrote:
>> Here?s my final updated patch that also ensures the posix_spawn_file_acti=
ons_addclosefrom_np symbol is appropriately weak, guarded by _NETBSD_SOURCE,=
 the libc version is updated, etc.
>>=20
>=20
> I still like it :-)

Thanks!

> One minor nit: making this visible (in include/spawn.h) only #ifdef _NETBS=
D_SOURCE
> might not be a good idea. I think it should be visible by default unless
> some stricte standard is requested.

I wasn=E2=80=99t sure what the rule would be on =E2=80=9CNetBSD-only=E2=80=9D=
 additions to POSIX-standardized bits. (Even though it=E2=80=99s not really N=
etBSD-only, and is present on Solaris and Linux and FreeBSD etc.)

Isn=E2=80=99t most everything on NetBSD built with _NETBSD_SOURCE set unless=
 specifically built otherwise? (E.g. with POSIX-conformance flags set.)

  =E2=80=94 Chris