Re: 16-bit depth on radeonfb
[email protected] Wed, 29 Jul 2026 13:17:43 +0200
| Newsgroups | gmane.os.netbsd.devel.kernel |
|---|---|
| Message-ID | <amnhV5j5dVbQnF1d@localhost> |
Hi Julian, Thanks for your comments. On Wed, Jul 29, 2026 at 11:02:43AM +0200, Julian Coleman wrote: > I think that's OK, apart from: > ... > where we change the default depth from 8 to 16. Yes, an extra #ifdef to allow every alternative would be cleaner. > I would suggest adding a RADEONFB_DEPTH_16 flag too and setting it in > your kernel config. Agreed, having flags for every depth would be best. I can not though test a changed patch right away. > It might make sense for it to be the default, I think so. > although I'm not sure - which arch are you running on? i386, my experience is of course arch-biased. > PS. Of course, we have multiple ways of doing this, so you could also add > flags on the device line itself: > > https://nxr.netbsd.org/xref/src/sys/arch/alpha/conf/GENERIC#539 > https://nxr.netbsd.org/xref/src/sys/dev/i2c/at24cxx.c#180 Thank you for the reference! Cheers /od2uvb