Re: A new network interface send queue API
Jason Thorpe <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.network |
|---|---|
| Message-ID | <[email protected]> |
> On Nov 12, 2023, at 6:54 PM, Taylor R Campbell <[email protected]> wrote: > > Couple more small questions: > > 9. Does ifq_restage this leave the packet (or its replacement) staged, > or does it undo the staging (and possibly replace the packet in the > queue) so that the next ifq_stage might return a different packet? Yes, the mbuf passed to ifq_restage() is placed into the on-deck circle, and will be the next mbuf returned by get / stage / etc. > 10. Maybe ifq_commit and ifq_abort should also take the staged packet > as an argument in order to detect and assert no misuse? Yah, that sounds reasonable. -- thorpej