Re: vlan and bpf
Jason Thorpe <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.network |
|---|---|
| Message-ID | <[email protected]> |
> On Dec 15, 2023, at 9:11 AM, Greg Troxel <[email protected]> wrote: > > --- if.c.~1.457.2.4.~ 2020-09-01 19:56:43.824457852 -0400 > +++ if.c 2023-12-15 12:10:09.503560965 -0500 > @@ -818,7 +818,8 @@ if_percpuq_softint(void *arg) > > while ((m = if_percpuq_dequeue(ipq)) != NULL) { > ifp->if_ipackets++; > - bpf_mtap(ifp, m, BPF_D_IN); > + if (!vlan_has_tag(m)) > + bpf_mtap(ifp, m, BPF_D_IN); Why would not not want to be able to sniff the VLAN-encapsulated packets on their physical interface? Seems like this change could lose a useful debugging aid... -- thorpej