Re: request review: burp

"Francis GUDIN" <[email protected]> writes:

> no feedback received until now.
> I doubt upgrading from such an ancient version of burp would break anybody's actual use of it.
> I couldn't swear it would build and run fine on every platform, but it's okay for my use-case on SmartOS.

Some of the problems in wip/burp exist in sysutils/burp, but pkglint
also shows a number of new problems.


/usr/pkgsrc/wip/burp > pkglint 
WARN: Makefile:28--30: Each sed command should appear in an assignment of its own.
NOTE: Makefile:28--30: The substitution command "'s,@PKG_SYSCONFDIR@,${PKG_SYSCONFDIR},'" can be replaced with "SUBST_VARS.dirs= PKG_SYSCONFDIR".
WARN: Makefile:44--47: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
WARN: PLIST:2: PLISTs should not contain empty lines.
WARN: PLIST:8: "man/man8/bedup.8" should be sorted before "share/burp/scripts/timer_script".
WARN: PLIST:12: "bin/vss_strip" should be sorted before "man/man8/vss_strip.8".
WARN: PLIST:16: "sbin/bsigs" should be sorted before "sbin/burp_ca".
ERROR: patches/patch-Makefile.am:3: Each patch must be documented.
ERROR: patches/patch-configs_certs_CA_CA.cnf.in:3: Each patch must be documented.
ERROR: patches/patch-configs_certs_CA_burp__ca.in:3: Each patch must be documented.
ERROR: patches/patch-configs_client_burp.conf.in:3: Each patch must be documented.
ERROR: patches/patch-configs_server_burp.conf.in:3: Each patch must be documented.
ERROR: patches/patch-configs_server_summary__script.in:3: Each patch must be documented.
ERROR: patches/patch-manpages_bedup.8.in:3: Each patch must be documented.
ERROR: patches/patch-manpages_burp.8.in:3: Each patch must be documented.
ERROR: patches/patch-manpages_burp__ca.8.in:3: Each patch must be documented.
9 errors, 6 warnings and 1 note found.
(Run "pkglint -e" to show explanations.)
(Run "pkglint -fs" to show what can be fixed automatically.)
(Run "pkglint -F" to automatically fix some issues.)