pkg/59915: shells/ksh93 fails on NetBSD current

>Number:         59915
>Category:       pkg
>Synopsis:       shells/ksh93 fails on NetBSD current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 14 06:30:00 +0000 2026
>Originator:     Kevin Bowling
>Release:        netbsd head (11.99.4), pkgsrc head (01/13/2025)
>Organization:
>Environment:
NetBSD kev-ws-t480.cv0.bbox.io 11.99.4 NetBSD 11.99.4 (GENERIC) #0: Tue Jan 13 02:48:42 MST 2026  [email protected]:/usr/obj/sys/arch/amd64/compile/GENERIC amd64

>Description:
The build fails in the embedded libast with an incompatible pointer type and then the internal struct statfs not being defined.  I am guessing a feature test has broken, maybe with gcc14.

+ cc -D_BLD_DLL -fPIC -D_BLD_ast -Os -O2 -fno-strict-aliasing -I. -I/usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast -
Icomp -I/usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/comp -Iinclude -I/usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src
/lib/libast/include -Istd -I/usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/std -c /usr/pkgsrc/shells/ksh93/work/ksh-
1.0.10/src/lib/libast/port/mnt.c                                                                                             
/usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/port/mnt.c: In function 'mntopen':                                   
/usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/port/mnt.c:272:24: error: passing argument 1 of 'getmntinfo' from inc
ompatible pointer type [-Wincompatible-pointer-types]                                                                        
  272 |         n = getmntinfo(&mp->next, 0);                                                                                
      |                        ^~~~~~~~~                                                                                     
      |                        |
      |                        struct statfs **
In file included from ./ast_fs.h:23,
                 from ./ast_fcntl.h:5,                   
                 from /usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/include/ast_std.h:66,
                 from /usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/include/ast.h:32,
                 from /usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/port/mnt.c:28:
/usr/include/sys/statvfs.h:160:20: note: expected 'struct statvfs **' but argument is of type 'struct statfs **'
  160 | int     getmntinfo(struct statvfs **, int)
      |                    ^~~~~~~~~~~~~~~~~
/usr/pkgsrc/shells/ksh93/work/ksh-1.0.10/src/lib/libast/port/mnt.c:279:29: error: invalid use of undefined type 'struct statf
s'

etc
>How-To-Repeat:
Build shells/ksh93 on current
>Fix: