Re: pkg/60017: textproc/uni2ascii: update to 4.20
"Bartosz Kuźma via gnats" <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.bugs |
|---|---|
| Message-ID | <[email protected]> |
The following reply was made to PR pkg/60017; it has been noted by GNATS. From: =?UTF-8?Q?Bartosz_Ku=C5=BAma?= <[email protected]> To: [email protected] Cc: [email protected], [email protected], [email protected] Subject: Re: pkg/60017: textproc/uni2ascii: update to 4.20 Date: Thu, 19 Feb 2026 16:12:09 +0100 --000000000000318aa2064b2ebb41 Content-Type: multipart/alternative; boundary="000000000000318aa1064b2ebb3f" --000000000000318aa1064b2ebb3f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Please add these two patches to solve this issue. On Thu, Feb 19, 2026 at 12:05=E2=80=AFAM Thomas Klausner via gnats < [email protected]> wrote: > The following reply was made to PR pkg/60017; it has been noted by GNATS. > > From: Thomas Klausner <[email protected]> > To: NetBSD bugtracking <[email protected]> > Cc: > Subject: Re: pkg/60017: textproc/uni2ascii: update to 4.20 > Date: Thu, 19 Feb 2026 00:01:24 +0100 > > On Wed, Feb 18, 2026 at 03:30:01AM +0100, [email protected] via > gnats wrote: > > >Synopsis: textproc/uni2ascii: update to 4.20 > > I tried this on NetBSD 11.99.5 with gcc 14, and the build fails for me > with: > > --- enttbl.o --- > enttbl.c: In function 'LookupCodeForEntity': > enttbl.c:560:8: error: implicit declaration of function 'strcmp' > [-Wimplicit-function-declaration] > 560 | c =3Dstrcmp(s,EntityCodeTable[m].name); > | ^~~~~~ > enttbl.c:24:1: note: include '<string.h>' or provide a declaration of > 'strcmp' > 23 | #include "unicode.h" > +++ |+#include <string.h> > 24 | > *** [enttbl.o] Error code 1 > > make[1]: stopped making "all-am" in > /tmp/textproc/uni2ascii/work/uni2ascii-4.20 > --- endian.o --- > mv -f .deps/endian.Tpo .deps/endian.Po > --- uni2ascii.o --- > uni2ascii.c:2692:1: error: return type defaults to 'int' [-Wimplicit-int= ] > 2692 | SubstituteChar(UTF32 c) { > | ^~~~~~~~~~~~~~ > uni2ascii.c:2706:1: error: return type defaults to 'int' [-Wimplicit-int= ] > 2706 | AddCustomSubstitution(char *str){ > | ^~~~~~~~~~~~~~~~~~~~~ > uni2ascii.c: In function 'main': > uni2ascii.c:3189:24: error: implicit declaration of function 'putu8' > [-Wimplicit-function-declaration] > 3189 | if(PassThroughP) putu8(c); > | ^~~~~ > *** [uni2ascii.o] Error code 1 > > I also tried adding > CFLAGS+=3D -Wno-implicit-function-declaration > CFLAGS+=3D -Wno-implicit-int > to the pkgsrc Makefile, but the pkgsrc CFLAGS are ignored. > > Can you please take a look at this? > > Thanks, > Thomas > > --=20 Pozdrawiam, Bartosz Ku=C5=BAma --000000000000318aa1064b2ebb3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Please add these two patches to solve this issue.</div><br= ><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D= "gmail_attr">On Thu, Feb 19, 2026 at 12:05=E2=80=AFAM Thomas Klausner via g= nats <<a href=3D"mailto:[email protected]">[email protected]</= a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p= x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Th= e following reply was made to PR pkg/60017; it has been noted by GNATS.<br> <br> From: Thomas Klausner <<a href=3D"mailto:[email protected]" target=3D"_blan= k">[email protected]</a>><br> To: NetBSD bugtracking <<a href=3D"mailto:[email protected]" target= =3D"_blank">[email protected]</a>><br> Cc: <br> Subject: Re: pkg/60017: textproc/uni2ascii: update to 4.20<br> Date: Thu, 19 Feb 2026 00:01:24 +0100<br> <br> =C2=A0On Wed, Feb 18, 2026 at 03:30:01AM +0100, <a href=3D"mailto:bartosz.k= [email protected]" target=3D"_blank">[email protected]</a> via gnats wro= te:<br> =C2=A0> >Synopsis:=C2=A0 =C2=A0 =C2=A0 =C2=A0textproc/uni2ascii: upda= te to 4.20<br> <br> =C2=A0I tried this on NetBSD 11.99.5 with gcc 14, and the build fails for m= e<br> =C2=A0with:<br> <br> =C2=A0--- enttbl.o ---<br> =C2=A0enttbl.c: In function 'LookupCodeForEntity':<br> =C2=A0enttbl.c:560:8: error: implicit declaration of function 'strcmp&#= 39; [-Wimplicit-function-declaration]<br> =C2=A0 =C2=A0560 |=C2=A0 =C2=A0 =C2=A0c =3Dstrcmp(s,EntityCodeTable[m].name= );<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~<br> =C2=A0enttbl.c:24:1: note: include '<string.h>' or provide a = declaration of 'strcmp'<br> =C2=A0 =C2=A0 23 | #include "unicode.h"<br> =C2=A0 =C2=A0+++ |+#include <string.h><br> =C2=A0 =C2=A0 24 |<br> =C2=A0*** [enttbl.o] Error code 1<br> <br> =C2=A0make[1]: stopped making "all-am" in /tmp/textproc/uni2ascii= /work/uni2ascii-4.20<br> =C2=A0--- endian.o ---<br> =C2=A0mv -f .deps/endian.Tpo .deps/endian.Po<br> =C2=A0--- uni2ascii.o ---<br> =C2=A0uni2ascii.c:2692:1: error: return type defaults to 'int' [-Wi= mplicit-int]<br> =C2=A0 2692 | SubstituteChar(UTF32 c) {<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0| ^~~~~~~~~~~~~~<br> =C2=A0uni2ascii.c:2706:1: error: return type defaults to 'int' [-Wi= mplicit-int]<br> =C2=A0 2706 | AddCustomSubstitution(char *str){<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0| ^~~~~~~~~~~~~~~~~~~~~<br> =C2=A0uni2ascii.c: In function 'main':<br> =C2=A0uni2ascii.c:3189:24: error: implicit declaration of function 'put= u8' [-Wimplicit-function-declaration]<br> =C2=A0 3189 |=C2=A0 =C2=A0 =C2=A0 =C2=A0if(PassThroughP) putu8(c);<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~<br> =C2=A0*** [uni2ascii.o] Error code 1<br> <br> =C2=A0I also tried adding<br> =C2=A0CFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 -Wno-implicit-function-declarat= ion<br> =C2=A0CFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 -Wno-implicit-int<br> =C2=A0to the pkgsrc Makefile, but the pkgsrc CFLAGS are ignored.<br> <br> =C2=A0Can you please take a look at this?<br> <br> =C2=A0Thanks,<br> =C2=A0 Thomas<br> <br> </blockquote></div><div><br clear=3D"all"></div><br><span class=3D"gmail_si= gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d= iv dir=3D"ltr">Pozdrawiam, Bartosz Ku=C5=BAma</div></div> --000000000000318aa1064b2ebb3f-- --000000000000318aa2064b2ebb41 Content-Type: application/octet-stream; name="patch-enttbl.c" Content-Disposition: attachment; filename="patch-enttbl.c" Content-Transfer-Encoding: base64 Content-ID: <f_mltlneg80> X-Attachment-Id: f_mltlneg80 JE5ldEJTRCQKCi0tLSBlbnR0YmwuYy5vcmlnCTIwMjYtMDItMTkgMTU6MDI6NTEuNDA1NDkwNjA1 ICswMDAwCisrKyBlbnR0YmwuYwpAQCAtMjEsNiArMjEsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5o IgogI2luY2x1ZGUgPHN0ZGxpYi5oPgogI2luY2x1ZGUgInVuaWNvZGUuaCIKKyNpbmNsdWRlIDxz dHJpbmcuaD4KIAogc3RydWN0IGVudCB7CiAgIGNoYXIgKm5hbWU7Cg== --000000000000318aa2064b2ebb41 Content-Type: application/octet-stream; name="patch-uni2ascii.c" Content-Disposition: attachment; filename="patch-uni2ascii.c" Content-Transfer-Encoding: base64 Content-ID: <f_mltlnegb1> X-Attachment-Id: f_mltlnegb1 JE5ldEJTRCQKCi0tLSB1bmkyYXNjaWkuYy5vcmlnCTIwMjYtMDItMTkgMTU6MDM6NDIuMTA3OTcw MjAzICswMDAwCisrKyB1bmkyYXNjaWkuYwpAQCAtMjY4OSw3ICsyNjg5LDcgQEAgaW50IFN1YnNB dmFpbGFibGUgPSAwOwogICogc2VhcmNoIG1heSBiZSBhZHZpc2FibGUuIEZvciB0aGUgdGltZSBi ZWluZyB3ZSBqdXN0IGRvIGEgbGluZWFyIHNlYXJjaC4KICAqLwogCi1TdWJzdGl0dXRlQ2hhcihV VEYzMiBjKSB7CitpbnQgU3Vic3RpdHV0ZUNoYXIoVVRGMzIgYykgewogICBpbnQgaTsKICAgZm9y KGkgPSAwOyBpIDwgU3ViQ250OyBpKyspIHsKICAgICBpZihjID09IFN1Ykxpc3RbaV0udSkgewpA QCAtMjcwMyw3ICsyNzAzLDcgQEAgU3Vic3RpdHV0ZUNoYXIoVVRGMzIgYykgewogICByZXR1cm4g MDsKIH0KIAotQWRkQ3VzdG9tU3Vic3RpdHV0aW9uKGNoYXIgKnN0cil7Cit2b2lkIEFkZEN1c3Rv bVN1YnN0aXR1dGlvbihjaGFyICpzdHIpewogICBjaGFyICpMZWZ0OwogICBjaGFyICpSaWdodDsK ICAgY2hhciAqRGVsaW07CkBAIC0yNzk4LDYgKzI3OTgsNyBAQCBpbnQgbWFpbiAoaW50IGFjLCBj aGFyICphdltdKQogICBleHRlcm4gaW50IG9wdG9wdDsKICAgZXh0ZXJuIFVURjMyIFVURjhpbihp bnQsaW50ICosdW5zaWduZWQgY2hhciAqKik7CiAKKyAgZXh0ZXJuIHZvaWQgcHV0dTggKHVuc2ln bmVkIGxvbmcpOwogICBleHRlcm4gaW50IENvdW50U2xvdHMoY2hhciAqKTsKICAgZXh0ZXJuIHZv aWQgTGlzdEZvcm1hdEFyZ3VtZW50cyhzaG9ydCk7CiAgIGV4dGVybiB2b2lkIFNldEZvcm1hdChj aGFyICosIGludCAqLCBzaG9ydCAqLGludCAqLCBzaG9ydCAqLCBzaG9ydCAqKTsK --000000000000318aa2064b2ebb41--