Re: pkg/59981: xentools418 rc.d/xencommons: test: -z: unexpected operator

The following reply was made to PR pkg/59981; it has been noted by GNATS.

From: Manuel Bouyer <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pkg/59981: xentools418 rc.d/xencommons: test: -z: unexpected
 operator
Date: Sat, 7 Mar 2026 11:58:00 +0100

 On Sun, Feb 08, 2026 at 06:45:01PM +0000, Robert Elz via gnats wrote:
 > The following reply was made to PR pkg/59981; it has been noted by GNATS.
 > 
 > From: Robert Elz <[email protected]>
 > To: [email protected], [email protected]
 > Cc: 
 > Subject: Re: pkg/59981: xentools418 rc.d/xencommons: test: -z: unexpected operator
 > Date: Mon, 09 Feb 2026 01:41:27 +0700
 > 
 >      Date:        Sun,  8 Feb 2026 04:45:00 +0000 (UTC)
 >      From:        "[email protected] via gnats" <[email protected]>
 >      Message-ID:  <[email protected]>
 >  
 >    | Arises from these conditionals -- first one is fine, second one is not:
 >    |
 >    | 	if test -n "$xenconsoled_pid" -a -n "$xenstored_pid";
 >  
 >  That's not fine, it just happens to work (currently), it should be
 >  
 >  	if test -n "$xenconsoled_pid" && test -n "$xenstored_pid"
 
 Why ? the man page for test(1) show -a being a valid option
 
 -- 
 Manuel Bouyer <[email protected]>
      NetBSD: 26 ans d'experience feront toujours la difference
 --