PR/60388 CVS commit: pkgsrc/textproc/xmlto

The following reply was made to PR pkg/60388; it has been noted by GNATS.

From: "David H. Gutteridge" <[email protected]>
To: [email protected]
Cc: 
Subject: PR/60388 CVS commit: pkgsrc/textproc/xmlto
Date: Wed, 1 Jul 2026 03:50:37 +0000

 Module Name:	pkgsrc
 Committed By:	gutteridge
 Date:		Wed Jul  1 03:50:37 UTC 2026
 
 Modified Files:
 	pkgsrc/textproc/xmlto: Makefile distinfo
 	pkgsrc/textproc/xmlto/patches: patch-xmlto_in
 
 Log Message:
 xmlto: apply two shell-related tweaks
 
 First, make shell code used in the "-o" option parsing more portable.
 "type -p" hasn't been supported by NetBSD's sh since 8.0 (and also
 isn't universally supported elsewhere by other shells). This addresses
 PR pkg/60388 from Andrew Cagney. (Really here we're suppressing a
 warning rather than a failure, one that happens to show up in build
 logs.)
 
 (We could substitute "command -v" instead (recommended over bare "type"
 by a NetBSD shell guru), but since both the existing upstream code and
 a bunch of our patches are already using "type" in many places, I kept
 it consistent here.)
 
 Next, Makefile r. 1.32 removed bash as a runtime dependency, but didn't
 account for REPLACE_BASH still being defined, which results in a broken
 (though effectively harmless) substitution to "#!". (Here perhaps the
 pkgsrc replacement mechanism could be improved so it generates an error
 when the replacement path is empty.) This is only relevant for the test
 target.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.50 -r1.51 pkgsrc/textproc/xmlto/Makefile
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/textproc/xmlto/distinfo
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/textproc/xmlto/patches/patch-xmlto_in
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.