Re: wip/chromium

On Sun, Jan 16, 2011 at 03:01:32PM +0100, Joerg Sonnenberger wrote:
> On Sun, Jan 16, 2011 at 12:06:11PM +0800, Rui-Xiang Guo wrote:
> > Program received signal SIGSEGV, Segmentation fault.
> > tcmalloc::ThreadCache::GetThreadHeap ()
> >     at third_party/tcmalloc/chromium/src/thread_cache.h:375
> > 375         return threadlocal_heap_;
> 
> threadlocal_heap_ is declared as __thread by chance?

Good hint. It is controled by HAVE_TLS -
    371 inline ThreadCache* ThreadCache::GetThreadHeap() {
    372 #ifdef HAVE_TLS
    373   // __thread is faster, but only when the kernel supports it
    374   if (KernelSupportsTLS())
    375     return threadlocal_heap_;
    376 #endif
    377   return reinterpret_cast<ThreadCache *>(
    378       perftools_pthread_getspecific(heap_key_)); 
    379 }

HAVE_TLS is defined if compiler supports __thread.

I disable the option manually. It looks better now and help me to find some
missing patches.

Is it safe to close it?

-rxg