Re: let me update mk/git-package.mk

Makoto Fujiwara <[email protected]> writes:

> If you make at wip/twittering-mode, 
> You may have following lines:
>
> + -----------------
> | t-105@makoto 11:21:50/120712(..wip/twittering-mode)% make clean && make patch                         
> | ===> Cleaning for twittering-mode-1.0nb20120712
> | ===> Skipping vulnerability checks.
> |      ... (snip) ...
> | 
> | => Build dependency checkperms>=1.1: found checkperms-1.11
> | => Full dependency emacs>=24.1<25: found emacs-24.1
> | ===> Overriding tools for twittering-mode-1.0nb20120712
> | ===> Extracting for twittering-mode-1.0nb20120712
> | error: SSL certificate problem: unable to get local issuer certificate while accessing https://github.com/hayamiz/twittering-mode.git/info/refs
> | fatal: HTTP request failed
> | *** Error code 128
> | 
> | Stop.
> | make: stopped in /export/CHROOT/usr/pkgsrc/wip/twittering-mode
> | *** Error code 1
> | 
> | Stop.
> | make: stopped in /export/CHROOT/usr/pkgsrc/wip/twittering-mode
> + -----------------
>
> This means we need 
>   -c http.sslVerify=false
> command option to git.
>
> I would like to commit following patch to fix this ,

> Index: mk/git-package.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc-wip/wip/mk/git-package.mk,v
> retrieving revision 1.13
> diff -u -r1.13 git-package.mk
> --- mk/git-package.mk	5 Dec 2011 14:43:23 -0000	1.13
> +++ mk/git-package.mk	12 Jul 2012 02:32:32 -0000
> @@ -18,6 +18,9 @@
>  #	GIT_TAG.${id}
>  #		Overridable GIT tag for a repository.
>  #
> +#	GIT_CMD_OPTION
> +#		Command line options, usually null string 
> +#		(The example is -c http.sslVerify=false for twittering-mode)
>  
>  .if !defined(_PKG_MK_GIT_PACKAGE_MK)
>  _PKG_MK_GIT_PACKAGE_MK=	# defined
> @@ -62,7 +65,7 @@
>  
>  USE_TOOLS+=		date pax
>  
> -_GIT_CMD=		git
> +_GIT_CMD=		git ${GIT_CMD_OPTION}

No. Please, deal with it consistently with cvs-package.mk and svn-package.mk.
cvs-package.mk is the primary reference.


-- 
HE CE3OH...

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/