Re: Request for review of wip/nx-client-bin
Rumko <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Lubomir Kundrak wrote: > Hi Rumko, > > On Sun, 2007-02-25 at 22:32 +0100, Rumko wrote: >> Hi! >> >> nxclient is a NoMachine NX client for remote access. This package installs >> the official NX linux binary client. >> >> Can someone please review it? > > Thank you for this package, it came just when I needed it :) > > I added a couple of missing dependencies and removed /dev/null from I automatically thought other thing would get depended on because of the libpng dependency and as for dev/null ... I didn't even notice that one :) > PLIST. I think you should write a more descriptive DESCR, not a > COMMENT-like one-liner, which tells basically nothing. When I made the package I was in a hurry and when I asked for the review I kinda forgot to check it one more time and expand it. > > Also, there's a RPM package of the program available. Is there a reason > why you you chose a tarball, not the RPM? I see many linux compat > packages are installed from RPM, which has an advantage of automatically > generating a PLIST, and... dunno what :) Does that package work with > SUSE? I had no idea how to create a package using RPM so I made the kind I knew how :) > > Regards, -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (DragonFly) iD8DBQFF40P1xV3ce2RZW70RArqQAJ4iZ5N+115KZwer5PI8ZvRlqSDAZgCg3Q6L Uo/h0U3p4Z9FLP/GGGZIP5I= =C3yS -----END PGP SIGNATURE----- ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV