Re: Request for dir2ogg review
Guillaume Lasmayous <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
OBATA Akio wrote: > On Tue, 18 Dec 2007 06:14:55 +0900, Guillaume Lasmayous <[email protected]> wrote: > > >> Please review wip/dir2ogg. Dir2ogg is a python script used to convert >> mp3 and wav files to ogg files, preserving tagging information during >> the conversion. >> It relies on py-mutagen to do the tags conversion. >> > > HOMEPAGE should point to parent directory. > You can use REPLACE_PYTHON to replace python's path, > and NO_BUILD=yes instead of empty do-build target, > and INSTALLATION_DIRS should include ${PKGMANDIR}/man1 too. > I think I corrected most of the issues you mentionned. Thanks to confirm everything is OK. And thanks for your answer, Guillaume. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/