Re: wip/gmp-ecm - reviews wanted

"OBATA Akio" <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
If this package is well known as GMP-ECM, should be
PKGNAME=	gmp-${DISTNAME}

It is usuall sufficient for configure
CONFIGURE_ARGS+=	--with-gmp=${BUILDLINK_PREFIX.gmp}

On Sat, 02 Feb 2008 21:55:35 +0900, Christian Sturm <[email protected]> wrote:

> Oh, I'm not sure when to add USE_LANGUAGES and LICENSE to the Makefile.
> Should I add them?

You should add c to USE_LANGUAGES if this package require cc to build.
But if GNU_CONFIGURE=yes, c is automatically added to USE_LANGUAGES
because gnu configure usually using c compiler.

LICENSE is required if the package is RESTRICTED to handle.
GMP-ECM's license is GNU GPL/LGPL, so no need to define LICENSE now.

-- 
"Of course I love NetBSD":-)
OBATA Akio / [email protected]


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.