Re: Request for wip/mirage review

Guillaume Lasmayous wrote:

> Adam Hoka wrote:
> > Guillaume Lasmayous wrote:
> >
> >   
> >> Hello,
> >>
> >> I just committed (I hope without errors) mirage 0.9.3, "a fast and 
> >> simple image viewer" build upon py-gtk2.
> >> Any comments welcome.
> >>     
> >
> > Hi!
> >
> > Do you have PKG_DEVELOPER=yes set in mk.conf?
> >
> > I got this:
> >
> > => Checking file-check results for mirage-0.9.3
> > ERROR: ************************************************************
> > ERROR: The following files are in /usr/pkg but not in the PLIST:
> > ERROR:         /usr/pkg/lib/python2.4/site-packages/mirage.py
> > ERROR:         /usr/pkg/share/applications/mirage.desktop
> > ERROR:         /usr/pkg/share/mirage/CHANGELOG
> > ERROR:         /usr/pkg/share/mirage/COPYING
> > ERROR:         /usr/pkg/share/mirage/README
> > ERROR:         /usr/pkg/share/mirage/TODO
> > ERROR:         /usr/pkg/share/mirage/TRANSLATORS
> > ERROR:         /usr/pkg/share/mirage/mirage_blank.png
> > ERROR:         /usr/pkg/share/mirage/stock_fullscreen.png
> > ERROR:         /usr/pkg/share/mirage/stock_leave-fullscreen.png
> > ERROR:         /usr/pkg/share/mirage/stock_shuffle.png
> > ERROR:         /usr/pkg/share/pixmaps/mirage.png
> >
> > It looks other way OK at first blink.
> >
> > ps.: You can use some more tabs for indentation to make it readable.
> >
> > --
> > Adam
> >   
> Hello Adam,
> 
> I don't really understand what went wrong here. I've never had these 
> messages on my machine. Should I add these to the PLIST ?
> Thanks in advance for your help.
> 
> Guillaume
> 

Yes, please.
They are installed on my system but i cant remove them because they are not in the PLIST.
I could just have fixed that, but I think you will learn more by correcting it than me. :)

Cheers,
--
Adam

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone