Re: new package: gallery2
"OBATA Akio" <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 08 Sep 2008 08:04:04 +0900, Fredrik Pettai <[email protected]> wrote: > On Sep 6, 2008, at 4:37 AM, OBATA Akio wrote: >>> do-install: >>> ${INSTALL_DATA} ${WRKDIR}/gallery2.conf ${EGDIR}/gallery2.conf >>> ${CP} -R ${WRKSRC}/* ${G2DIR} >>> ${CHMOD} 666 ${G2DIR}/config.php >>> ${INSTALL_DATA} ${FILESDIR}/.htaccess ${G2DIR}/.htaccess >> >> You can add DESTDIR support. > > I fixed most of the things you "enlightened" me about by commenting my > package submissions. > But I'm not sure how you mean I should do with adding DESTDIR support? > I didn't find much documented about DESTDIR in the pkgsrc doc. > What benefit does it offer? And how should I call it in the Makefile? > (I've looked in several other Makefiles of some other packages, and > there are lot of ways that DESTDIR is called/used...) The pkgsrc guide 5.3. Variables affecting the installation process 19.6.4. Adding DESTDIR support to packages For this package, it's easy to support DESTDIR. Just define PKG_DESTDIR_SUPPORT=user-destdir and change do-install target to installation directory prefixed with ${DESTDIR}. So I suggested to add DESTDIR support. -- "Of course I love NetBSD":-) OBATA Akio / [email protected] ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/