Re: new package: wip/dcc (Distributed Checksum Clearinghouses)

On Tue, Dec 23, 2008 at 05:23:31PM +0100, Petar Bogdanovic wrote:
> On Tue, Dec 23, 2008 at 10:46:07AM -0500, Greg Troxel wrote:
> > 
> > Petar Bogdanovic <[email protected]> writes:
> > 
> > > On Tue, Dec 23, 2008 at 09:33:44AM -0500, Greg Troxel wrote:
> > >> 
> > >> Petar Bogdanovic <[email protected]> writes:
> > >> So, the question is whether there should even be options, or just build
> > >> it all.  What bad thing would happen if all three options were defaulted
> > >> to on?
> > >> 
> > >> I suspect Vernon would prefer that we always include dccd, so as to
> > >> maximally encourage running a server.  It seems that dccd would be ok,
> > >> just a few more bits.  Leaving the option lets someone who is for some
> > >> reason both filtering mail and tight on space cope, but it seems dccd
> > >> should be present in default builds.
> > >
> > > The only disadvantage when adding dccd is that you'll pollute your
> > > dcc_home with configuration files only used by dccd.. which is a bit
> > > disencouraging if you just want to use one of the clients. At least
> > > that's what my impression was when I first did a default install. :)
> > 
> > I see - but with the dccproc man page and the spamassassin help, one
> > doesn't need to look :-)
> > 
> > >> (A nit is that --disable-server should also omit the server man pages.)
> > >
> > > I tried to keep it default and follow what `make install' does. And it
> > > leaves not just the man pages but also the configuration examples for
> > > dccd. (and maybe a few other things)
> > 
> > That's totally reasonable.  pkgsrc is really not the place to fix things
> > like that - should be reported/fixed upstream.
> > 
> > > Also there is no way to disable the cgi-bin stuff which is the only
> > > reason why the package depends on perl.
> > 
> > Sure there is: add a patch that removes it from Makefile.  But I'm not
> > sure one should do that - perl is big, but the odds of someone wanting
> > dcc and not already having perl seem low.
> 
> Sorry, what I wanted to say is that there is no way to disable the
> cgi-bin stuff over configure.
> 
> 
> Let me sum up:
> 
> 	- Leave the options and do not split the package until someone
> 	  complains. Default enabled options will be `dccd dccifd' while
> 	  `dccm' will be disabled.
> 
> 	- Add a examples/dcc_spamassassin.cf file which can easily be
> 	  copied to /etc/pkg/spamassassin in order to enable DCC.pm
> 	  properly.
> 
> 	- Mention examples/dcc_spamassassin.cf in MESSAGES.

Done:

   /cvsroot/pkgsrc-wip/wip/dcc/MESSAGE,v
   new revision: 1.2; previous revision: 1.1

   /cvsroot/pkgsrc-wip/wip/dcc/Makefile,v
   new revision: 1.3; previous revision: 1.2

   /cvsroot/pkgsrc-wip/wip/dcc/PLIST,v
   new revision: 1.2; previous revision: 1.1

   /cvsroot/pkgsrc-wip/wip/dcc/files/dcc-spamassassin.cf,v
   initial revision: 1.1


BTW: How is your dccifd working, Greg?

------------------------------------------------------------------------------