Re: new packages: arora, cclive, lxrandr

Sébastien BOCAHU <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
> All packages except wip/arora are built successfully under Linux.
> 
> http://mova.org/~cheusov/pub/pkgsrc-distbb/Linux/current/logs/test/META/report.html

> wip/arora failed because of broken qt4-tools.

Thank you for reviewing :)

> Just a minor notes. In my view, it makes sense to convert
> 
>     DISTNAME= gpicview-0.1.11
>     PKGREVISION=    1
>     CATEGORIES= graphics
>     MASTER_SITES=   ${MASTER_SITE_SOURCEFORGE:=lxde/}
> 
> to something like
> 
>     DISTNAME=       gpicview-0.1.11
>     PKGREVISION=    1
>     CATEGORIES=     graphics
>     MASTER_SITES=   ${MASTER_SITE_SOURCEFORGE:=lxde/}
> 
> Also see output of 'pkglint -Wall' command.

Thanks for the tip (I didn't know about -Wall).
I agree with you concerning the indents.

I've corrected my Makefiles.

regards,

-- 

Sébastien BOCAHU - zecrazytux

http://zecrazytux.net
[email protected]
zecrazytux @ #labo-linux #labo-linux.bsd @ irc.freenode.org

Please avoid sending me files in proprietary formats,
such as microsoft word or excel.
Please use open standards instead (for example, pdf).
Plain text is *really* appreciated !


------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and 
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today. 
Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
pkgsrc-wip-review mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.