Re: cfengine3 pkg

On Sun, Aug 02, 2009 at 01:10:39PM -0400, matthew sporleder wrote:
> Hey, guys.  I whipped up a simple cfengine3 package but it's less
> sophisticated than the cfengine(2) pkg that's already in wip.  The
> upgrade is pretty major so I thought it was appropriate to add a new
> package.
> 
> Any comments or definite things to do on this one?

Looks good in general, some nits:
. pkglint has two complaints.
. Does the "b" in the DISTNAME stand for "beta"? Then this should be
made explicit, e.g. PKGNAME=${DISTNAME:S/b/beta/}
. DESCR could be more verbose (see cfengine)
. "cfengine is a" in COMMENT is redundant
. you can remove the url2pkg-marker now...

I haven't ever used cfengine, so I can't comment on if it works or if
it's useful :)
 Thomas

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july