Re: wip/sphinsearch

On Thu, 01 Oct 2009 22:45:48 +0900, Filip Hajny <[email protected]> wrote:

> Just imported wip/sphinxsearch. Would love some advice on these
> warnings from pkglint:
>
> WARN: options.mk:4: Unknown option "iconv".
> WARN: options.mk:5: Unknown option "iconv".
> WARN: PLIST:7: Redundant library found. The libtool library is in line
> 8.
> WARN: PLIST:9: Redundant library found. The libtool library is in line
> 8.
>
> Assuming the first two have to do with the fact that the option name
> is not a standard pkgsrc one? That's fine then.

Yes.

> The latter two ones - I'm not sure. Is the proper way to persuade/
> patch the package's install target to stop copying .a and .la lib files?

No, just remove them (and lib/libsphinxclient-0.0.1.so?) from PLIST,
because they will be generated automatically from .la files
(shlib file names are platform depend).


Some more suggestions:
  * No need to contains ${DESTDIR}${PREFIX} in INSTALLATION_DIRS.
    If it is relative paths, assumed as in ${PREFIX}.

  * If this package require either mysql or postgresql, you should use PKG_OPTIONS_REQUIRED_GROUPS.
    (ref. www/ja-trac/options.mk)

-- 
"Of course I love NetBSD":-)
OBATA Akio / [email protected]

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf