Re: lcdproc

On Thu, Nov 05, 2009 at 11:49:20AM -0600, Larson, Timothy E. wrote:
> Please review this package.  I've been working with upstream to verify NetBSD and Solaris support, and the newest release (the first in some time) has that.  So I'd like to see this imported to pkgsrc.

It doesn't compile on NetBSD-5.99.21/amd64:
machine_NetBSD.c:53:28: error: machine/apmvar.h: No such file or directory
machine_NetBSD.c: In function 'machine_get_battstat':
machine_NetBSD.c:98: error: storage size of 'apmi' isn't known
machine_NetBSD.c:109: error: 'APM_IOC_GETPOWER' undeclared (first use in this function)
machine_NetBSD.c:109: error: (Each undeclared identifier is reported only once
machine_NetBSD.c:109: error: for each function it appears in.)
machine_NetBSD.c:117: error: 'APM_AC_OFF' undeclared (first use in this function)
machine_NetBSD.c:120: error: 'APM_AC_ON' undeclared (first use in this function)
machine_NetBSD.c:123: error: 'APM_AC_BACKUP' undeclared (first use in this function)
machine_NetBSD.c:98: warning: unused variable 'apmi'

Probably because amd64 has no apm support.

The package looks ok.

INSTALLATION_DIRS is only needed if the package doesn't create the
needed directories itself, most using auto* should be fine, so you can
probably remove the line.

Cheers,
 Thomas

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july