Re: Please review umefont-ttf package.
Aleksey Cheusov <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
> Hi,
> Please review wip/umefont-ttf and send me comments.
> It is my first font package.
0 umefont-ttf>pkglint -Wall
NOTE: Makefile:16: Alignment of variable values should be done with tabs, not spaces.
NOTE: Makefile:17: Alignment of variable values should be done with tabs, not spaces.
NOTE: Makefile:18: Alignment of variable values should be done with tabs, not spaces.
WARN: Makefile:50: FONTS_DIRS.ttf may not be used in this file.
WARN: Makefile:50: Please use ${FONTS_DIRS.ttf:Q} instead of ${FONTS_DIRS.ttf}.
0 errors and 2 warnings found.
0 umefont-ttf>
It makes sense to fix tabs vs. spaces warnings,
maybe others too.
Minor note: why not derive version in PKGNAME from DISTNAME?
In this case version number should be specified only once.
Ex:
--- Makefile 24 Dec 2009 13:40:31 -0000 1.2
+++ Makefile 24 Dec 2009 23:24:45 -0000
@@ -2,7 +2,7 @@
#
DISTNAME= umefont-410
-PKGNAME= umefont-0.410
+PKGNAME= ${DISTNAME:S/-/-0./}
CATEGORIES= fonts japanese
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE_JP:=ume-font/22212/}
--
Best regards, Aleksey Cheusov.
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev