Re: Please review wip/p5-Audio-Scan
Thomas Klausner <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Feb 09, 2010 at 10:05:41AM +0900, OBATA Akio wrote: > This message is probably too late because this package is imported to pkgsrc, > but resent (rejected by mailing list). > > audio/libid3tag have one security patch. > I want to track two packages for one security issue. Good point. I made it compile, but it fails many of its tests, so I probably did something wrong. Ideas? Thomas ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ pkgsrc-wip-review mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
p5-Audio-Scan.diff
(text/plain, 1.8 KB)
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/p5-Audio-Scan/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile 8 Feb 2010 21:06:29 -0000 1.1.1.1
+++ Makefile 9 Feb 2010 10:25:19 -0000
@@ -14,7 +14,10 @@
PKG_DESTDIR_SUPPORT= user-destdir
PERL5_PACKLIST= auto/Audio/Scan/.packlist
-USE_LIBTOOL= yes
+MAKE_ENV+= NO_LIBID3TAG=1
+MAKE_ENV+= ID3TAG_LIBS="-L${BUILDLINK_PREFIX.libid3tag}/lib ${COMPILER_RPATH_FLAG}${BUILDLINK_PREFIX.libid3tag}/lib"
+
+.include "../../audio/libid3tag/buildlink3.mk"
.include "../../lang/perl5/module.mk"
.include "../../mk/bsd.pkg.mk"
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/audio/p5-Audio-Scan/distinfo,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 distinfo
--- distinfo 8 Feb 2010 21:06:29 -0000 1.1.1.1
+++ distinfo 9 Feb 2010 10:25:19 -0000
@@ -3,3 +3,4 @@
SHA1 (Audio-Scan-0.58.tar.gz) = 6684756d686de2cd77c7ce6b20cb723a9329e64f
RMD160 (Audio-Scan-0.58.tar.gz) = c709d6189c205afac61390a20327c9ddf1b6e98c
Size (Audio-Scan-0.58.tar.gz) = 2811290 bytes
+SHA1 (patch-aa) = 4cacf7cf34b3cdc9016582d439de65f0f424338f
Index: patches/patch-aa
===================================================================
RCS file: patches/patch-aa
diff -N patches/patch-aa
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-aa 9 Feb 2010 10:25:19 -0000
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- Makefile.PL.orig 2009-10-17 01:38:41.000000000 +0000
++++ Makefile.PL
+@@ -46,7 +46,7 @@ else {
+ if ( $ENV{NO_LIBID3TAG} ) {
+ # Link to external libid3tag
+ *MY::postamble = sub {};
+- push @LIBPATH, '-L' . $ENV{ID3TAG_LIBS} if $ENV{ID3TAG_LIBS};
++ push @LIBPATH, $ENV{ID3TAG_LIBS} if $ENV{ID3TAG_LIBS};
+ push @LIBS, '-lid3tag';
+ }
+ else {