Re: Please review dbskkd-cdb and skk-jisyo-cdb
Ryo ONODERA <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
From: "OBATA Akio" <[email protected]> Subject: Re: Please review dbskkd-cdb and skk-jisyo-cdb Date: Sun, 22 Aug 2010 18:30:57 +0900 > On Mon, 16 Aug 2010 20:57:39 +0900, Ryo ONODERA <[email protected]> wrote: > >> Please review dbskkd-cdb and skk-jisyo-cdb. > > For skkjisyo-cdb, I feel dependency on tinycdb should be BUILD_DEPENDS. > And for cdb command, you should not use ${PREFIX}, use mk/find-prefix.mk instead. > PREFIX may be vary by package. > (and it is also paths for SKK-JISYO.L.cdb in dbskkd-cdb). Thanks for your reviews. I fixed issues. -- Ryo ONODERA // [email protected] PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3 ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d