Re: Please review wip/xvkbd
"OBATA Akio" <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 01 Sep 2010 01:37:46 +0900, Ryo ONODERA <[email protected]> wrote: >> x11/xmascot will help you. > > Makefile of x11/xmascot does not have the word, XAW_TYPE. > Is it good example? Oops, my fault. It is not committed yet :( (part of my w.i.p. cleaning of xaw dependency, I've forgotten it...) .include "../../mk/xaw.buildlink3.mk" .if ${XAW_TYPE} == "3d" || ${XAW_TYPE} == "xpm" SUBST_CLASSES+= xaw SUBST_STAGE.xaw= pre-configure SUBST_FILES.xaw= config.tmpl SUBST_SED.xaw= -e 's/undef USE_XAW3D/define USE_XAW3D/' .endif > I want to know how to use XAW_TYPE variable properly. > I think that graphics/graphviz is bad example probably. Yes, XAW_TYPE is user settable variable, it should not be set in pkg's Makefile. -- OBATA Akio / [email protected] ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd