Re: Please review opencascade
Silas Silva <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Nov 02, 2010 at 10:14:14PM +0200, Aleksey Cheusov wrote: > > I just commited wip/opencascade. Could you please review it? > > Is there any reason for EXTRACT_SUFX=.tgz? Yeah, if I don't put it, pkgsrc look for .tar.gz and don't find it. It was added automatically by url2pkg. > And, did you consider keeping PKGNAME in the same case as DISTNAME > with _src removed? That was my mortal doubt from the beginning. Since the majority of pkgsrc packages are lowercase, and OpenCASCADE package names are lowercase for FreeBSD ports and Ubuntu's apt, I decided to make it lowercase too. Any recommendations? Thanks. -- Silas Silva ------------------------------------------------------------------------------ Achieve Improved Network Security with IP and DNS Reputation. Defend against bad network traffic, including botnets, malware, phishing sites, and compromised hosts - saving your company time, money, and embarrassment. Learn More! http://p.sf.net/sfu/hpdev2dev-nov