Re: Please review discount, wkhtmltopdf, xerces-c and xqilla
"OBATA Akio" <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
Just a quick review. On Thu, 04 Nov 2010 07:16:07 +0900, Sébastien BOCAHU <[email protected]> wrote: > * Discount, a C markdown implementation 1. --mandir in CONFIGURE_ARGS is broken (missing `/'). 2. need to create target directories before install. 3. you can install manual pages too. 4. you can define TSET_TARGET. 5. `pkglint -Wall -Call' crean. > * Wkhtmltopdf, to print XHTML/CSS to PDF (build against pkgsrc's Qt, so only > basic features are available. Wkhtmltopdf folks patch Qt to add extra features) 1. '_' should be removed from PKGNAME. 2. no need to add `make' to USE_TOOLS. 3. honor CONFIGURE_ENV for do-configure target. 4. no need to do-install target, just add to INSTALL_MAKE_FLAGS. 5. pkglint clean > * XQilla, a XPath 2 and XQuery command line and library processor 1. any reason to define do-configure target whereas GNU_CONFIGURE=yes? 2. ${PREFIX} is the prefix of this package, not of xerces-c pacakge. 3. pkglint clean -- OBATA Akio / [email protected] ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today http://p.sf.net/sfu/msIE9-sfdev2dev _______________________________________________ pkgsrc-wip-review mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review