Re: Please review logrotate
Nils Ratusznik <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
----- Mail original -----
> I cannot fetch DISTFILES, so just look at package's Makefile.
>
> 1. ${PKG_SYSCONFDIR} != ${PREFIX}/etc, for SUBST_*.confs.
> 2. and etc/logrotate.d also, maybe not in ${PREFIX}.
> 3. you can use `SUBST_VARS.*= PREFIX' instead of `SUBST_SED.*'
> if using `@PREFIX@' instead of `__PREFI__'.
Hi,
thanks for your review. I specified both gentoo and freebsd master sites, I hope it will help with fetching problems.
I also commited changes for #3, but haven't looked yet #1 and #2.
Nils
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev