Re: Please review logrotate
Nils Ratusznik <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
----- Mail original -----
> ----- Mail original -----
>
> > I cannot fetch DISTFILES, so just look at package's Makefile.
> >
> > 1. ${PKG_SYSCONFDIR} != ${PREFIX}/etc, for SUBST_*.confs.
> > 2. and etc/logrotate.d also, maybe not in ${PREFIX}.
> > 3. you can use `SUBST_VARS.*= PREFIX' instead of `SUBST_SED.*'
> > if using `@PREFIX@' instead of `__PREFI__'.
> Hi,
>
> thanks for your review. I specified both gentoo and freebsd master
> sites, I hope it will help with fetching problems.
> I also commited changes for #3, but haven't looked yet #1 and #2.
Hi,
I think I corrected all three points. Could you please review it again?
Thanks !
Nils
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl