Re: Please review wip/fop
Thomas Klausner <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jan 13, 2011 at 09:37:14AM +0100, Francois Tigeot wrote: > > Also it would be nice if bin/fop already set the JAVA_HOME environment > > variable correctly. In my environment I get > > Error: JAVA_HOME is not defined correctly. > > We cannot execute java > > unless I run "JAVA_HOME=/usr/pkg/java/openjdk7 fop". > > Is there an existing framework / package example I could use ? I suggest adding a patch for bin/fop that does JAVA_HOME=@JAVA_HOME@ around line 87 and then using SUBST_SED to replace "@JAVA_HOME@" with the value of the variable from pkgsrc (see section 19.1.12 in the pkgsrc guide for SUBST_SED). grep will give you lots of examples for SUBST_SED. Thomas ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl