Re: Please review wip/gcc45
Ryo ONODERA <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
Hi, From: "Kai-Uwe Eckhardt" <[email protected]>, Date: Sun, 27 Feb 2011 16:15:02 +0100 >> I have tested on DragonFly/i386 2.8.2. >> With PKG_DEVELOPER=YES in mk.conf file, I have gotten following error. >> >> I think this error is generated because fixincl file contains string >> /usr/tmp/wip/gcc45/work/.tools/bin/sed (I have WRKOBJDIR=/usr/tmp line >> in mk.conf). > > The Makefile tries to fix this by setting lt_cv_path_SED using MAKE_ENV > and since this is a copy of the gcc44 Makefile, the question arise if > lang/gcc4 yields the same error ? The variable lt_cv_path_SED is > used in libtool.m4 and libjava/libltdll/configure and acinclude.m4. > Java is disabled for NetBSD in the Makefile, so mabey it is a problem > in libjava but not in libtool.m4. I just started a build with > PKG_DEVELOPER=YES to check if there is a similar problem on NetBSD. > But since the java build is broken on NetBSD I can't check that part. I have not try to build lang/gcc44. According to configure script of wip/gcc45, lt_cv_path_SED should be ac_cv_path_SED. Following patch resolve the error I had reported. But I does not confirmed wip/gcc45 is working properly or not, "make package" is ok for me on NetBSD 5.99.47. Thank you. Index: Makefile =================================================================== RCS file: /cvsroot/pkgsrc-wip/wip/gcc45/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- Makefile 23 Feb 2011 19:16:53 -0000 1.3 +++ Makefile 27 Feb 2011 20:42:17 -0000 @@ -131,7 +131,7 @@ # ${WRKSRC}/fixincludes/ looks for sed and compiles the path to sed into # a binary so we need to make sure we give it the installed sed and not # the tool wrapped one. -MAKE_ENV+= lt_cv_path_SED=${TOOLS_SED} +MAKE_ENV+= ac_cv_path_SED=${TOOLS_SED} CPPFLAGS+= -I${BUILDLINK_DIR}/include CFLAGS+= -I${BUILDLINK_DIR}/include -- Ryo ONODERA // [email protected] PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3 ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev