Can I update wip/py-pcapy?

Alexander Nasonov <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.user,gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
The patch below updates py-pcapy to 0.10.5, removes a kludge for
NetBSD 1.6.1-stable, adds destdir support and a license.

I'm a bit unsure about the license. It's apache 1.1 with substitutions
in company a product names and without the trailer in
licenses/apache-1.1:

 * This software consists of voluntary contributions made by many
 * individuals on behalf of the Apache Software Foundation.  For more
 * information on the Apache Software Foundation, please see
 * <http://www.apache.org/>.
 *
 * Portions of this software are based upon public domain software
 * originally written at the National Center for Supercomputing Applications,
 * University of Illinois, Urbana-Champaign.

Pcapy page states that "This software is provided under a slightly
modified version of the Apache Software License. Feel free to review it
here and compare it to the official Apache Software License."

I take the _slightly modified_ words from the authoritative source
as a "license" to set LICENSE=apache-1.1 in the package Makefile.

Can I commit the below change to pkgsrc-wip?

Thanks,
Alex


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc-wip/wip/py-pcapy/Makefile,v
retrieving revision 1.10
diff -p -u -u -r1.10 Makefile
--- Makefile	9 Sep 2009 11:22:11 -0000	1.10
+++ Makefile	17 May 2011 19:18:13 -0000
@@ -1,7 +1,7 @@
 # $NetBSD$
 #
 
-DISTNAME=		pcapy-0.10.2
+DISTNAME=		pcapy-0.10.5
 PKGNAME=		${PYPKGPREFIX}-${DISTNAME}
 CATEGORIES=		net
 MASTER_SITES=		http://oss.corest.com/repo/
@@ -9,35 +9,13 @@ MASTER_SITES=		http://oss.corest.com/rep
 MAINTAINER=		[email protected]
 HOMEPAGE=		http://oss.corest.com/projects/pcapy.html
 COMMENT=		Python interface to pcap library
+LICENSE=		apache-1.1
 
 PY_PATCHPLIST=		yes
 PYDISTUTILSPKG=		yes
+USE_LANGUAGES=		c c++
+PKG_DESTDIR_SUPPORT=	user-destdir
 
 .include "../../lang/python/extension.mk"
-
-###########################################################################
-# WARNING!
-#
-# this is only temporary solution because of braindead buildlink3.mk
-# "autoconfiguration"; on 1.6.1-stable system this will _not_ build just
-# because -stable has too old pcap library.
-###########################################################################
-
-BUILD_DEPENDS+=		libpcap>=0.7.2:../../net/libpcap
-BUILDLINK_PACKAGES+=	libpcap
-EVAL_PREFIX+=		BUILDLINK_PREFIX.libpcap=libpcap
-BUILDLINK_PREFIX.libpcap_DEFAULT=	${LOCALBASE}
-BUILDLINK_FILES.libpcap=	include/pcap.h
-BUILDLINK_FILES.libpcap+=	include/pcap-namedb.h
-BUILDLINK_FILES.libpcap+=	include/net/bpf.h
-BUILDLINK_FILES.libpcap+=	lib/libpcap.*
-BUILDLINK_TARGETS+=	libpcap-buildlink
-libpcap-buildlink: _BUILDLINK_USE
-
-#
-# If the buildlink wasn't broken, I could use this:
-#
-# .include "../../net/libpcap/buildlink3.mk"
-#
-
+.include "../../net/libpcap/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc-wip/wip/py-pcapy/distinfo,v
retrieving revision 1.2
diff -p -u -u -r1.2 distinfo
--- distinfo	28 Sep 2005 06:41:37 -0000	1.2
+++ distinfo	17 May 2011 19:18:13 -0000
@@ -1,5 +1,5 @@
 $NetBSD$
 
-SHA1 (pcapy-0.10.2.tar.gz) = eca552e1daf53ba570f1f27a9939e0ad1a46abb8
-RMD160 (pcapy-0.10.2.tar.gz) = 190cc9f1117e22713b104947f7ec28b0eb21ed1b
-Size (pcapy-0.10.2.tar.gz) = 18651 bytes
+SHA1 (pcapy-0.10.5.tar.gz) = e7e803b423f2c2e3401ee616cddfd6ab237fc8d8
+RMD160 (pcapy-0.10.5.tar.gz) = fef424f4b912ba73e95e192355a0ad2e527492ff
+Size (pcapy-0.10.5.tar.gz) = 18884 bytes
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.