Re: Please review wip/grub2

On Mon, Jun 06, 2011 at 02:02:27AM +0200, Grégoire Sutre wrote:
> I've updated wip/grub2 to the latest release (1.99).  The package
> has been tested on NetBSD 5.99.47 (i386), NetBSD 5.1 (amd64) and
> Debian GNU/Linux (wheezy/sid).
> 
> The makefile is a bit more complex than it should, since the
> package name, the commands, manuals, etc. are renamed from `grub'
> to `grub2', to avoid conflict with sysutils/grub.
> 
> There is a single patch file that applies the same fix to a bunch
> of scripts.  IMO, keeping all these changes in the same patch file
> improves readability.  But I can split the patch in 10 patches if
> that's the way to go.

Since it's always modifying '. ${libdir}/grub/grub-mkconfig_lib',
perhaps you can replace it with another SUBST_SED instead?

Another issue: when the freetype option is turned on, options.mk
manually downloads a file. Please don't do that. Instead, add
DISTFILES=${DISTNAME}${EXTRACT_SUFX} to the first block in the main
Makefile, and do "DISTFILES+=unifont-5.1.20080820.pcf.gz" in
options.mk; additionally
SITES.unifont-5.1.20080820.pcf.gz=http://unifoundry.com/
will let pkgsrc know from where to fetch it.
I haven't tried but guess that the file will automatically be unpacked
into WRKDIR, so you might need a post-extract target renaming it (or
unpacking and renaming it, if I'm wrong).

Hope this helps,
 Thomas

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev