Re: Please review wip/grub2

On 06/18/2011 12:00 PM, Thomas Klausner wrote:
> On Mon, Jun 06, 2011 at 02:02:27AM +0200, Grégoire Sutre wrote:
>> I've updated wip/grub2 to the latest release (1.99).  The package
>> has been tested on NetBSD 5.99.47 (i386), NetBSD 5.1 (amd64) and
>> Debian GNU/Linux (wheezy/sid).
>>
>> The makefile is a bit more complex than it should, since the
>> package name, the commands, manuals, etc. are renamed from `grub'
>> to `grub2', to avoid conflict with sysutils/grub.
>>
>> There is a single patch file that applies the same fix to a bunch
>> of scripts.  IMO, keeping all these changes in the same patch file
>> improves readability.  But I can split the patch in 10 patches if
>> that's the way to go.
>
> Since it's always modifying '. ${libdir}/grub/grub-mkconfig_lib',
> perhaps you can replace it with another SUBST_SED instead?

That's true.  My intention here is to avoid mixing modifications that
that I would like to get integrated upstream (in patches) with the
rest (SUBST_SED in the Makefile).  But I can live without it.


> Another issue: when the freetype option is turned on, options.mk
> manually downloads a file. Please don't do that. Instead, add
> DISTFILES=${DISTNAME}${EXTRACT_SUFX} to the first block in the main
> Makefile, and do "DISTFILES+=unifont-5.1.20080820.pcf.gz" in
> options.mk; additionally
> SITES.unifont-5.1.20080820.pcf.gz=http://unifoundry.com/
> will let pkgsrc know from where to fetch it.
> I haven't tried but guess that the file will automatically be unpacked
> into WRKDIR, so you might need a post-extract target renaming it (or
> unpacking and renaming it, if I'm wrong).

Thanks for the tip.  I've fixed the package.

Best,

Grégoire


------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2