Re: Please review wip/iodine
Moritz Wilhelmy <[email protected]> Mon, 6 Aug 2012 17:57:21 +0200
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 06, 2012 at 22:44:05 +0900, OBATA Akio wrote: > On Mon, 06 Aug 2012 22:28:47 +0900, Moritz Wilhelmy <[email protected]> wrote: > > >> For man page, "man/iodine.8" should be installed as "man8/iodined.8" and/or "man1/iodine.1". > > > > I believe the client too needs to run as root in order to be able to set > > up a tun(4) interface and configure an IP address on it, therefore I put > > them both in sbin (as on e.g. debian) and installed the manpages in > > section 8. Please correct me, in case this is wrong. > > My bad. > I reviewed the package before your last update. > > > Should a pseudo-user with a chroot directory be added? > > How about an rc.d script for iodined? > > If it is usual usage, yes, it should be nice. Well, since the administrator would have to edit the parameters[1] anyway, and iodine is something I - and I suppose most users - would start on demand (e.g. while traveling), I decided not to create an rc.d script for neither iodined nor iodine. Another question would be if the MESSAGE is really any useful or necessary. Is it possible to expand ${VARBASE} while printing the MESSAGE? Anyway, any other comments? Best ragards, Moritz [1] In order to use iodine, you need to create an NS record for a domain and supply it as a parameter to iodine. Also, you may want to set an environment variable for IODINE_PASSWORD or IODINED_PASSWORD, depending on whether your machine is the client or server. Otherwise, it prompts for the password, which may be annoying, especially in non-interactive scenarios, and it would also affect an rc-script. There's also a commandline switch available to set the password, but since it is by default visible to all users with a login on the machine this way (via ps), I'd advise against using it. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/