Re: Please review wip/iodine

On Mon, 6 Aug 2012 14:03:05 +0200
Moritz Wilhelmy <[email protected]> wrote:

> After fiddling around with wip/iodine (because the need for it arose), I
> think it's now ready for import.

Thanks for working on this,


On Mon, 06 Aug 2012 14:22:47 -0400
Greg Troxel <[email protected]> wrote:

> It sounds like iodine needs a config file to get this from, but that's
> an upstream bug.

Considering that its not rare for distributions to provide config files
for tools, it would also be possible to provide example configuration
file(s) in files/ and to install it/them under examples/ at
post-install, i.e.:

INSTALLATION_DIRS+=share/examples/iodine

post-install:
	${INSTALL_DATA} ${FILESDIR}/foo.conf ${DESTDIR}${PREFIX}/share/examples/iodine/foo.conf

(of course these then also should be in PLIST)

It's also possible to then decide that one/some of the example(s)
should also be copied as necessary to a configuration directory (if the
user has custom modifications, these won't get deleted by pkg_delete or
overwritten by pkg_add):

CONF_FILES+=${PREFIX}/share/examples/iodine/foo.conf ${PKG_SYSCONFDIR}/foo.conf

If we do such, I'm not saying that we shoudn't recommend to the
upstream maintainer to also include those as part of the iodine
distribution in the future :)

Thanks,
-- 
Matt

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/