Re: Please review wip/polarssl
Moritz Wilhelmy <[email protected]> Mon, 13 Aug 2012 23:25:31 +0200
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
Hi, ASau@ proposed to use BSD_INSTALL_DATA for static libraries, which is what I currently do. Also thanks to him, PKGSRC_RUN_TESTSUITE now determines whether or not the testsuite is run. Aside from this, I switched the package over to use the options framework, in order to be able to disable building and installing the apparently mostly demonstrational programs. With these changes made, would you please review the package again and import into pkgsrc, if you deem it ready? Best regards, Moritz PS: I found this bug in pkglint: Use of uninitialized value in concatenation (.) or string at /usr/pkg/bin/pkglint line 4777. WARN: options.mk:16: Permission [set] requested for PLIST_SRC, but only [] is allowed. I believe the concatenated value belongs between the brackets. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/