Re: Please review wip/iodine
Moritz Wilhelmy <[email protected]> Thu, 16 Aug 2012 15:30:58 +0200
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 16, 2012 at 09:20:39 -0400, Greg Troxel wrote: > > Moritz Wilhelmy <[email protected]> writes: > > > On Wed, Aug 15, 2012 at 21:23:50 +0200, Georg Schwarz wrote: > >> I just installed wip/iodine on MacOS. > >> > >> I ended up like this: > >> > >> ===> Install binary package of iodine-0.6.0rc1 > >> $NetBSD$ > >> > >> An iodine user and an empty directory suitable for chrooting have been created > >> for your convenience. > >> > >> imac:iodine schwarz$ > >> > >> I don't think that's true since I installed as an unprivileged user. > >> Is that text supposed to be shown on MacOS??? > > > > I don't think so, however I believe that I'm not doing anything unusual. > > If it's about installing users, I think that's about unprivileged > installs, not about MacOS. Yes, but then maybe the corresponding variables (PKG_USERS, PKG_GROUPS) should be ignored by pkgsrc in case of an unprivileged install, which apparently happens (and I haven't been understanding the mail right the first time). Anyway, the PKG_MESSAGE is wrong in this case, because the user/group will not have been created, and the /var/chroot/iodine directory will have the wrong permissions, presumably (i.e. owned by Georg's UID/GID rather than iodine/iodine). However, since there is no rc.d-script, there should be some way to notify people who do "normal" non-unprivileged builds that a user was created, no? Maybe pkgsrc should show that a user was created after displaying PKG_MESSAGE? I think it currently doesn't do that. Best regards, Moritz ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/