Re: please review wip/polarssl

Greg Troxel <[email protected]> Mon, 19 Nov 2012 08:48:02 -0500
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
DESCR should mention GPL in passing; a library intended to be usable in
embedded products being GPL is not what I'd expect.  (I don't mean to
object to someone writing and distributing a library, or to it being
packaged.  I would just expect that most actual products would rule it
out, so it seems good to add "GPL-licensed" to the DESCR (not to be
pointed; just add the words so people perceive reality efficiently).

pkglint complains:

ERROR: patches/patch-Makefile:1: "$NetBSD$" expected.
ERROR: patches/patch-Makefile:1: Comment expected.


Is PKGSRC_RUN_TEST documented in the guide?  I have been unclear on how
this is supposed to work, but it seems sensible.

Why is REPLACE_PERL outside of ifdef while USE_TOOLS is in?


It probably needs FETCH_USING=curl due to https; it won't fetch for me.

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov

_______________________________________________
pkgsrc-wip-review mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
signature.asc (application/pgp-signature, 194 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (NetBSD)

iEYEARECAAYFAlCqOJIACgkQ+vesoDJhHiWLCwCffTn1b/xBjxCIhaOJ6bbsrmtv
B4QAoJqqUkSvTe6GlaYWHygfvCJuMXp/
=zpbh
-----END PGP SIGNATURE-----