Re: please review wip/polarssl

Tim Larson <[email protected]> writes:

  [polarssl]

> Any other comments?  If not, would someone kindly import it before Q4 branch?

I looked at and it seems mostly ok.

'make test' fails with many lines like

   - test_suite_pbkdf2
  Shared object "libpolarssl.so.0" not found

either with the package installed or without.

It seems the build system doesn't use autoconf/libtool and doesn't cope
with doing the things people who say autoconf is too compliated forget
about :-)

But serious, in tests/Makefile:
 
  LDFLAGS += -L../library -lpolarssl $(SYS_LDFLAGS)

there is no RPATH handling.


It doesn't seem fair to hold up import on this (instead of just
disabling the test target), since we don't require tests, but it seems
fixable.

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d

_______________________________________________
pkgsrc-wip-review mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (NetBSD)

iEYEARECAAYFAlDCBQ4ACgkQ+vesoDJhHiVBKwCgjVm+IBQ5dBape9Figz5vmgdo
JT8AoI3k6RRF9S8ADYpJKmhL18xk2x+0
=+23F
-----END PGP SIGNATURE-----