Re: Please review wip/glib2

I saw that mistake looming when I changed it to jb-wip...

I just changed it to wip, and of course it will have to be changed back 
to devel when committed.

Thanks.

On 2/8/13 11:48 AM, Greg Troxel wrote:
> diffing from devel/glib2:
>
>    -DISTINFO_FILE=         ${.CURDIR}/../../devel/glib2/distinfo
>    -PATCHDIR=              ${.CURDIR}/../../devel/glib2/patches
>    +DISTINFO_FILE=         ${.CURDIR}/../../jb-wip/glib2/distinfo
>    +PATCHDIR=              ${.CURDIR}/../../jb-wip/glib2/patches
>
> this seems wrong; perhaps wip?
>
> glib-gio-kqueue-2.32.4-v3.patch is missing from distinfo.  Is that
> intended?
>
>    It also disables converting libiconv_open() calls on Darwin in
>    hacks.mk.  This hack appears to be
>    obsolete.  The package builds for me on Darwin without the hack using
>    either PREFER_PKGSRC
>    or PREFER_NATIVE (Xcode gcc).  Not sure if I overlooked some other
>    reason for the hack.
>
> On which version did you test?  Do you think it is ok all the way back
> to 10.6?


-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Jason W. Bacon
[email protected]
http://personalpages.tds.net/~jwbacon
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb