Re: review request for ifstat and libifstat

Hi,

On Sat, 30 Mar 2013 07:29:00 +0900, Florian Geiges <[email protected]> wrote:

> please review the 'ifstat' and 'libifstat' packages. the 'ifstat' package has been updated to address obvious open issues. both packages build nicely with PKG_DEVELOPER=yes.
> please let me know if any changes are required before these can pass the review stage.

Both packages are marked as PKG_DESTDIR_SUPPORT=none,
it means files will be installed into ${PREFIX} directly.
It should be fixed.

In `libifstat' package, `do-postinstall' target will try to remove files
installed as `fstat' package. It means installation of libifstat will break
already installed fstat package.
Anyway, the target must be `post-install' instead of `do-postinstall',
moreover, INSTALL_TARGET=install-libifstat.a should be used instead.

In options.mk, there are many options for statistics gathering methods,
but neither of them are enabled by default.
Its configure script require any of them, so you should set appropriate
valures to PKG_SUGGESTED_OPTIONS, PKG_OPTIONS_REQUIRED_GROUPS and/or
PKG_OPTIONS_NONEMPTY_SETS.

-- 
OBATA Akio / [email protected]

------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete 
for recognition, cash, and the chance to get your game on Steam. 
$5K grand prize plus 10 genre and skill prizes. Submit your demo 
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2