Re: theama package

[email protected] Wed, 5 Jun 2013 08:13:08 -0400
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
It looks good, mostly. Just a few suggestions:

1) Use ${MASTER_SITE_SOURCEFORGE:=theama/}
2) HOMEPAGE would be better as http://theama.sourceforge.net/
3) Your patch hardcodes PDB and it assumes that PREFIX=/usr/pkg. You could use the SUBST framework to fix it, like you're doing with the Makefile, which is quick and easy, although it doesn't fix the problem upstream

------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j