Re: theama package
Franck Lesage <[email protected]> Thu, 6 Jun 2013 11:19:24 +0200 (CEST)
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
Thank you for the reply. I followed your suggestions and committed the changes. On Wed, 5 Jun 2013, [email protected] wrote: > It looks good, mostly. Just a few suggestions: > > 1) Use ${MASTER_SITE_SOURCEFORGE:=theama/} > 2) HOMEPAGE would be better as http://theama.sourceforge.net/ > 3) Your patch hardcodes PDB and it assumes that PREFIX=/usr/pkg. You could use the SUBST framework to fix it, like you're doing with the Makefile, which is quick and easy, although it doesn't fix the problem upstream > > ------------------------------------------------------------------------------ > How ServiceNow helps IT people transform IT departments: > 1. A cloud service to automate IT design, transition and operations > 2. Dashboards that offer high-level views of enterprise services > 3. A single system of record for all IT processes > http://p.sf.net/sfu/servicenow-d2d-j > _______________________________________________ > pkgsrc-wip-review mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review > ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j