Re: wip/munge

Thomas Klausner <[email protected]> Thu, 24 Apr 2014 10:59:31 +0200
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
On Tue, Apr 22, 2014 at 02:56:15PM -0500, Jason Bacon wrote:
> Please review wip/munge.  It contains a minor PLIST fix for installing 
> on CentOS Linux.

It packages fine for me on NetBSD-6.99.40/amd64.
However, pkglint has quite a number of complaints:
ERROR: Makefile: Each package must define its LICENSE.
WARN: Makefile:16: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
WARN: Makefile:19: "$(VARBASE)/lib/munge" is not a valid pathname.
WARN: Makefile:19: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
WARN: Makefile:19: "$(VARBASE)/log/munge" is not a valid pathname.
WARN: Makefile:19: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
WARN: Makefile:19: "$(VARBASE)/run/munge" is not a valid pathname.
WARN: Makefile:19: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
ERROR: PLIST.FreeBSD:1: "@comment $NetBSD$" expected.
ERROR: PLIST.Linux:1: "@comment $NetBSD$" expected.
ERROR: PLIST.NetBSD:1: "@comment $NetBSD$" expected.
ERROR: patches/patch-src_etc_Makefile.in:3: Comment expected.
5 errors and 7 warnings found. (Use -e for more details.)

Can you please fix these?

Thanks,
 Thomas

------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform