Re: wip/munge

Thomas Klausner <[email protected]> writes:

> On Tue, Apr 22, 2014 at 02:56:15PM -0500, Jason Bacon wrote:
>> Please review wip/munge.  It contains a minor PLIST fix for installing 
>> on CentOS Linux.
>
> It packages fine for me on NetBSD-6.99.40/amd64.
> However, pkglint has quite a number of complaints:
> ERROR: Makefile: Each package must define its LICENSE.
> WARN: Makefile:16: The user-defined variable VARBASE is used but not added to BUILD_DEFS.

Since when is VARBASE "user-defined"?
It is as much user-defined as PREFIX or any other variable fixed at bootstrap.

> WARN: Makefile:19: "$(VARBASE)/lib/munge" is not a valid pathname.

This is well-known bug in pkglint: pkglint doesn't understand Make syntax.

> ERROR: patches/patch-src_etc_Makefile.in:3: Comment expected.

Are we requiring comments to trivial patches?
Why and what for? It is as much useful as "increase variable by 1".

> 5 errors and 7 warnings found. (Use -e for more details.)
>
> Can you please fix these?

It would be nice, if we don't request contributors to work around bugs in broken tools.


-- 
HE CE3OH...


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs