Re: wip/munge

--===============3802623690217991086==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Thomas Klausner <[email protected]> writes:

> On Wed, Apr 30, 2014 at 11:10:50AM +0400, Aleksej Saushev wrote:
>> > ERROR: patches/patch-src_etc_Makefile.in:3: Comment expected.
>>=20
>> Are we requiring comments to trivial patches?
>
> Yes.
>
>> Why and what for? It is as much useful as "increase variable by 1".
>
> To make live easier for other people updating packages, or for
> yourself after you've forgotten what you've done months or years ago.
> A one line comment saves reading a 40-line patch.

Also, the comment should explain if the bug has been filed upstream
(with a reference to the upstream tracker), or why it's not appropriate
to do so.  A persistent problem in pkgsrc has been accumulating patches
that don't get sent upstream.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlNg7/YACgkQ+vesoDJhHiUAOACfc4EokqsbCKBSgVjYQ0Kw6ZIo
hOoAnRQItcXWGIWB6f/d5/TsPrVAcGPy
=GtGF
-----END PGP SIGNATURE-----
--=-=-=--


--===============3802623690217991086==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
--===============3802623690217991086==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pkgsrc-wip-review mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review

--===============3802623690217991086==--