Re: Please review dbus-python

Rui-Xiang Guo <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <20060201114437.GA12754@hive>
On Tue, Jan 31, 2006 at 07:07:37PM +0100, Thomas Klausner wrote:
> On Mon, Jan 30, 2006 at 01:21:33PM +0800, Rui-Xiang Guo wrote:
> > Could someone please help to review dbus-python? (pls cvs update first)
> > It added the Python support for D-BUS which we need for some programs -
> > like the lastest rox-session. :)
> > 
> > p.s. TODO:2 - It seems harmless and we may ignore it. :)

Hi, Thomas.

> Suggestions:
> Rename the package to py-dbus, and let the pkgname contain
> PYPKGPREFIX.

But it will not look like a pair with dbus-glib. We still have some pkg names
as *-python in pkgsrc -
/usr/pkgsrc/www/ap-python
/usr/pkgsrc/www/ap2-python
/usr/pkgsrc/devel/boost-python
/usr/pkgsrc/graphics/dia-python
/usr/pkgsrc/graphics/vtk-python

What's the naming rule?

> TODO 1 is probably not necessary -- or does it link against
> an object of py-pyrex?

In fact, no. :)

> Other than that, it looks ok.

Thanks for reviewing.


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.